Slack alarm forwarder #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39
slackAlarmForwardersender alarminfo til en slack-kanal (#kompetansekartlegging-aws-alarms)slackAlarmForwardersubscribes til${ENV}-system-admin-topicslack_webhook_urltemplatesMan må manuelt legge inn verdi til secret-en
slack_webhook_urletter første deploy til dev og prod.Årsaken til at kontekst-variabel ikke brukes til å sette verdi er at secret-verdier vises i cdk outputs, ref aws/aws-cdk#5810 (comment), som kan være dumt når vi etterhvert deployer via GitHub Actions. Tenker at det også er greit å unngå enda en kontekstvariabel, spesielt siden denne kun hadde vært nødvendig å bruke én gang per miljø for å gi verdi til secret-en. I tillegg unngår vi at varsler fra sandboxes havner i slack-kanalen.