Ascendex Apis #4531
Open
Ascendex Apis #4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wodepig
commented
Jul 20, 2022
wodepig
commented
- Add most of the REST APIs
- rewrite Dtos of lombok
- AscendexDigest.java:Fixed url path problem of authentication signature
- ascendexApiInfo.json:The API information needed for the real test
- add param
added 9 commits
July 14, 2022 21:10
walec51
reviewed
Oct 23, 2022
| private String userUID; | ||
| private Boolean tradePermission; | ||
| private Boolean transferPermission; | ||
| private Boolean viewPermission; |
There was a problem hiding this comment.
please fix you coding conventions, we do not use tabs, indent should be 2 spaces
this also indicates that you did not build the project using maven as it would fix formatting for you
| */ | ||
| @Data | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor |
There was a problem hiding this comment.
please use @Value instead of the above
| /** | ||
| * Package:org.knowm.xchange.ascendex.dto.account | ||
| * Description: | ||
| * |
There was a problem hiding this comment.
these comments look unnecessary
| AccountCategory toAccount; | ||
|
|
||
| public void setAsset(String asset) { | ||
| this.asset =asset==null?null: asset.toUpperCase(); |
There was a problem hiding this comment.
mapping should be done in *Adapter classes, not in dtos
dtos should represent what came from the API
|
is there any progress on this PR? if not I will have to close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.