Fix detection of special case for constant evaluation #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aannleax
force-pushed
the
fix/optimize-constants
branch
from
35a1e75 to
5f3eab2
Compare
monsterkrampe
approved these changes
Jun 6, 2024
Once we also handle that, I think it'll make sense to pull this functionality out into some generic piece of code called by the constructors – for now, the current approach is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have special handling for expressions like
?x = 5, which uses theseek-function to quickly skip over values. However, the detection of this case was previously broken, so that we instead evaluated a= 5function for each entry.This PR should fix this problem and also has the observed performance benefits of #484.