fix: revoke cert should return empty response

knrdl · Jul 31, 2023 · 1d2ecc9 · 1d2ecc9
1 parent cfcdd88
commit 1d2ecc9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/acme/certificate/router.py b/app/acme/certificate/router.py
@@ -40,7 +40,7 @@ async def download_cert(
     return Response(content=pem_chain, headers=response.headers, media_type='application/pem-certificate-chain')
 
 
-@api.post('/revoke-cert')
+@api.post('/revoke-cert', response_class=Response)
 async def revoke_cert(data: Annotated[RequestData[RevokeCertPayload], Depends(SignedRequest(RevokeCertPayload, allow_new_account=True))]):
     """
     https://www.rfc-editor.org/rfc/rfc8555#section-7.6

diff --git a/tests/run.sh b/tests/run.sh
@@ -156,10 +156,10 @@ docker run -it --rm --name test_uacme2 --net test_net -v "$PWD/uacmedata:/uacme"
      bash -c "nginx -g 'daemon on;' && uacme -vvv -c /uacme -h /usr/share/uacme/uacme.sh \
      --acme-url http://acme.example.org:8080/acme/directory issue host30.example.org"
 
-echo "uacme 3"
+echo "uacme 3 (missing email addr on account registration)"
 docker run -it --rm --name test_uacme1 --net test_net \
      uacme uacme -v -y -c /tmp \
-     --acme-url http://acme.example.org:8080/acme/directory new || true
+     --acme-url http://acme.example.org:8080/acme/directory new 2>&1 | grep urn:ietf:params:acme:error:malformed