Implement SQLiteBatch::Close

knst · Oct 14, 2020 · 6636a26 · 6636a26
1 parent 9382535
commit 6636a26
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/wallet/sqlite.cpp b/src/wallet/sqlite.cpp
@@ -182,6 +182,14 @@ SQLiteBatch::SQLiteBatch(SQLiteDatabase& database)
 
 void SQLiteBatch::Close()
 {
+    // If m_db is in a transaction (i.e. not in autocommit mode), then abort the transaction in progress
+    if (m_database.m_db && sqlite3_get_autocommit(m_database.m_db) == 0) {
+        if (TxnAbort()) {
+            LogPrintf("SQLiteBatch: Batch closed unexpectedly without the transaction being explicitly committed or aborted\n");
+        } else {
+            LogPrintf("SQLiteBatch: Batch closed and failed to abort transaction\n");
+        }
+    }
 }
 
 bool SQLiteBatch::ReadKey(CDataStream&& key, CDataStream& value)