Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files from package #22

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

f440
Copy link
Contributor

@f440 f440 commented Aug 17, 2024

This pull request updates the *.gemspec file to optimize the gem package size and structure. The changes include:

  • Modified files to exclude test files, Rakefile, and CI related files from the package.
  • Removed the deprecated test_files specification as it is no longer recommended.

As a result of this change, the size of the unpacked package file will be reduced from 664KB to 60KB, achieving a reduction of approximately 90%.

Benefits:

  • Shorter download times for users
  • Reduced container sizes when the gem is included

References:

Copy link
Owner

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. test_files should be obsolete by now.

@knu knu merged commit 43cf699 into knu:master Aug 17, 2024
@knu
Copy link
Owner

knu commented Aug 17, 2024

Oh, this broke test:

test.test_files = gemspec.test_files

@f440 f440 deleted the remove-unused-files-from-package branch August 18, 2024 01:44
@f440
Copy link
Contributor Author

f440 commented Aug 18, 2024

Ah, I missed that. I just saw that you've already fixed the issue in the recent commit. Thanks so much for picking up on that so quickly! Sorry for any trouble I caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants