Switch to File::open() instead of spawning cat to avoid waiting on sp…

…awned process
knurling-rs · Jan 10, 2025 · 085efcf · 085efcf
1 parent 264f1e4
commit 085efcf
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 6 deletions.
diff --git a/xtask/output_files/net.out b/xtask/output_files/net.out
diff --git a/xtask/snapshot_elfs/hints_inner b/xtask/snapshot_elfs/hints_inner
diff --git a/xtask/snapshot_elfs/net b/xtask/snapshot_elfs/net
diff --git a/xtask/snapshot_elfs/timestamp b/xtask/snapshot_elfs/timestamp
diff --git a/xtask/src/print_snapshot.rs b/xtask/src/print_snapshot.rs
@@ -30,19 +30,15 @@ pub fn test_single_print_snapshot(name: &str) -> anyhow::Result<()> {
     let frame_path = format!("xtask/output_files/{}.out", name);
     let elf_path = format!("xtask/snapshot_elfs/{}", name);
 
-    let frames = Command::new("cat")
-        .arg(frame_path)
-        .stdout(Stdio::piped())
-        .spawn()
-        .unwrap();
+    let frames = std::fs::File::open(frame_path)?;
 
     let actual = run_capturing_stdout(
         Command::new("defmt-print")
             .arg("-e")
             .arg(elf_path)
             .arg("--log-format")
             .arg("{L:4} {s}")
-            .stdin(Stdio::from(frames.stdout.unwrap())),
+        .stdin(Stdio::from(frames)),
     )
     .with_context(|| name.to_string())?;