Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support f64 #346

Closed
jonas-schievink opened this issue Jan 18, 2021 · 0 comments · Fixed by #354
Closed

Support f64 #346

jonas-schievink opened this issue Jan 18, 2021 · 0 comments · Fixed by #354
Labels
breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request

Comments

@jonas-schievink
Copy link
Contributor

This should work just like f32 already does. I see no harm in providing this, since defmt won't do any f64 arithmetic on the device either way, just encoding it as raw bytes.
@jonas-schievink jonas-schievink added type: enhancement Enhancement or feature request good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes difficulty: easy Pretty easy to solve breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version labels Jan 18, 2021
@jonas-schievink jonas-schievink mentioned this issue Jan 21, 2021
Merged
bors bot added a commit that referenced this issue Jan 21, 2021
@bors @jonas-schievink
Merge #354 #355
a05a0c0 
354: f64 support r=japaric a=jonas-schievink

Closes #346

355: Clarify docs on `Write::write` r=japaric a=jonas-schievink

Fixes #168

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors bors bot closed this as completed in 4e58508 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

f64 support
1 participant
@jonas-schievink