write! macro
#263
Merged
write! macro
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
added
the
pr waits on: author
jonas-schievink
force-pushed
the
write
branch
from
3ec4a49 to
f8ed94b
Compare
jonas-schievink
force-pushed
the
write
branch
from
f8ed94b to
696bdc5
Compare
|
This now implements a more limited, but backwards-compatible version where you can only call |
jonas-schievink
added
pr waits on: review
japaric
approved these changes
Nov 24, 2020
| @@ -750,44 +750,6 @@ pub fn debug_assert_ne_(ts: TokenStream) -> TokenStream { | |||
| .into() | |||
| } | |||
|
|
|||
| // TODO share more code with `log` | |||
| #[proc_macro] | |||
| pub fn winfo(ts: TokenStream) -> TokenStream { | |||
| } | ||
|
|
||
| defmt::info!( | ||
| "nested `Format` impls using `write!`: {:?}", |
There was a problem hiding this comment.
💯 (this is a test case I was going to suggest)
| impl Format for MyStruct { | ||
| fn format(&self, fmt: &mut defmt::Formatter) { | ||
| defmt::write!(fmt, "one"); | ||
| defmt::write!(fmt, "two"); |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104
Closes #97 (
winfo!is removed)