-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add defmt::panic! #266
Merged
add defmt::panic! #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of printing 'left' and 'right' lines (which will have the same content) print a single line
jonas-schievink
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
|
||
let block = &f.block; | ||
quote!( | ||
#[export_name = "_defmt_panic"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc #252
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #136
this implements
defmt::panic!
which callsdefmt::error!
and then "panics"by default,
defmt::panic!
will "panic" by callingcore::panic!
. This preserves the panicking behavior (e.g. abort on panic, reset on panic, etc.) but can result in the panic message being printed twice -- this is the case if you usepanic_probe
(+print-defmt)to prevent printing the panic message twice, the panicking behavior of
defmt::panic
can be overridden using the#[defmt::panic_handler]
attribute, which works about the same as#[core::panic_handler]
but expects afn() -> !
function (note: no argument)the idea is that end users will replicate their
#[panic_handler]
panicking behavior, and omit the 'print the panic message' part, in the#[defmt::panic_handler]
function, for example:we can do the above for all new users of app-template so they don't run into the 'panic message printed twice':
TODO
preludedidn't work you can't override core's prelude items using a glob importFIXME
assert_ne
as a color-diff but shouldn't