Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Format for char #304

Merged
merged 4 commits into from
Dec 15, 2020
Merged

impl Format for char #304

merged 4 commits into from
Dec 15, 2020

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 15, 2020

this is a rebased version of #282
closes #282
closes #186

The change adds support to parse a char argument from a format string,
e.g.`defmt::info("x={:char}", 'y')`. For now the char is converted and
written as `u32` without any compression or using UTF8.

This is mainly to have tests and format in place, it can be iterated on.
@japaric
Copy link
Member Author

japaric commented Dec 15, 2020

bors r+

@japaric
Copy link
Member Author

japaric commented Dec 15, 2020

bors r-

@bors
Copy link
Contributor

bors bot commented Dec 15, 2020

Canceled.

@japaric
Copy link
Member Author

japaric commented Dec 15, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 15, 2020

Build succeeded:

@bors bors bot merged commit 8fa18fa into main Dec 15, 2020
@bors bors bot deleted the gh186-rebased branch December 15, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement Format for char
2 participants