impl<T> Format for PhantomData<T> #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Thanks for the PR! This looks good. Could you please extend the snapshot test in firmware/qemu/src/bin/log.rs to test that something like S { x: PhantomData<u8>, y: u8 } is correctly formatted by {=[?]}? I'd like to confirm that the tag is omitted when you format a slice of PhantomDatas and the whole thing is properly decoded.
mattico
force-pushed
the
phantomdata-fmt
branch
from
43e1792 to
74c481f
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this to be able to
#[derive(Format)]on a few structs.