add defmt-itm #335
Merged
add defmt-itm #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
commented
Jan 12, 2021
| static ENABLED: AtomicBool = AtomicBool::new(false); | ||
|
|
||
| /// Enables defmt logging over the ITM stimulus port 0 | ||
| pub fn enable(itm: ITM) { |
There was a problem hiding this comment.
we may want to make the stimulus port configurable in the feature that can be added backwards compatibility by adding a second function with signature fn(ITM, port_number: u8)
japaric
commented
Jan 12, 2021
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a new defmt transport crate