Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display full version with --help #352

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

Javier-varez
Copy link
Contributor

No description provided.

Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I left one request in the comments.

// structopt uses the clap API
// (this is only called once so it's not that bad)
Box::leak(Box::<str>::from(output))
println!("{}", env!("CARGO_PKG_VERSION").to_string());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you include the tool name here as well? so it prints defmt-print 0.1.0 on the first line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will upload a change for it.

Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@japaric
Copy link
Member

japaric commented Jan 22, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 22, 2021

Build succeeded:

@bors bors bot merged commit a57f6c1 into knurling-rs:main Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants