Make defmt-logger more configurable, remove probe-run strings #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
changed the title
Otherwise we'd duplicate this code both in probe-run and in defmt-print
Lotterleben
approved these changes
Feb 12, 2021
Co-authored-by: Lotte Steenbrink <lotte.steenbrink@ferrous-systems.com>
|
bors r=Lotterleben |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
defmt-loggerso that it does not make decisions about what data to include. It adds more API surface that can be used to write custom loggers, and removes any assumptions about being used byprobe-runfrom the existing logger.Closes #356