Disable logging calls via conditional compilation when all defmt features are disabled #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, yeah, and this has only gone through cursory testing and only on Windows. If there's a sensible place for me to introduce a test for this behavior, I'd be happy to do that; I don't see any tests for these macros as of now. |
|
Thanks, this looks good! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on fixing #411. It's not clear whether this is the "right" fix, as that issue was marked with a "medium" difficulty tag which would seem to imply there was more work expected here. Either way, it allows the sample in the linked issue to build for me, and fixes the usage in my own project.
The change here is to replace an "if" emitted by the logging macros (albeit with constant boolean conditions at macro evaluation time) with an explicit
#[cfg(...)]annotation. With the new form, the compiler seems to successfully strip out the unreachable macro body and as such there are no broken references to the nonexistent symbols.