Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate "crate version" from "wire format version" #540

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Jul 18, 2021

Depends on #539. Fixes #287.

This decouples the "wire format version" from the crate version (Cargo package version or git commit). Wire format version can now be bumped independently. This alleviates pains listed in #539., and more importantly it will allow making breaking changes to the wire format in a semver-minor defmt crate release. See #426.

Version is 3 to be able to retroactively number 0.1.x = 1, 0.2.x = 2. A followup PR will add support to defmt-decoder to decode both version 2 and 3 concurrently.

@Dirbaio Dirbaio marked this pull request as draft July 18, 2021 05:18
@Dirbaio Dirbaio marked this pull request as ready for review July 18, 2021 05:41
@Urhengulas
Copy link
Member

Urhengulas commented Jul 20, 2021

Hi @Dirbaio, Can you please resolve the merge conflict? 😁

@Urhengulas
Copy link
Member

Urhengulas commented Jul 20, 2021

Heh, your change makes #518 pretty-much obsolete 🙈 I will revert it (#545).

Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though some in-code docs would be good to have here, since this is quite important to get right.

src/lib.rs Show resolved Hide resolved
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 27, 2021

Build succeeded:

@bors bors bot merged commit c7b20d5 into knurling-rs:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate "crate version" from "wire format version"
3 participants