Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chrono with time to avoid pulling in old, vulnerable versions of time #725

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

Yatekii
Copy link
Contributor

@Yatekii Yatekii commented Jan 20, 2023

No description provided.

@Yatekii Yatekii force-pushed the fix/remove-chrono branch 2 times, most recently from 9546116 to e8c0fe8 Compare January 20, 2023 18:00
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yatekii, The PR looks good 😀 I only have one question regarding the .max.

decoder/src/log/json_logger.rs Outdated Show resolved Hide resolved
@Yatekii Yatekii requested a review from Urhengulas January 23, 2023 17:38
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

Build succeeded:

  • ci

@bors bors bot merged commit f9e99fc into knurling-rs:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants