Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye bors #756

Merged
merged 3 commits into from
May 17, 2023
Merged

Goodbye bors #756

merged 3 commits into from
May 17, 2023

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented May 15, 2023 •
edited
Loading

The publicly hosted instance of bors-ng is deprecated. Therefore we switch to GitHub merge queue (docs).

Two things are happening:

  • This PR edits config files to switch from bors to the new github merge queue.
  • Additionally the branch protection rules for the main branch are edited:
    • Require a pull request before merging
    • Require approval
    • Require status checks to pass before merging
      --> mark all checks as required
    • Require branches to be up to date before merging
    • Require merge queue
      --> keep default values

I am a bit unsure how to test this without creating a huge amount of pull requests, but I hope the changed settings already take effect for this PR.

@Urhengulas Urhengulas requested review from justahero and jonathanpallant and removed request for justahero May 15, 2023 17:16
@Urhengulas Urhengulas added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit aceeaa0 May 17, 2023
@Urhengulas Urhengulas deleted the goodbye-bors branch May 17, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urhengulas @jonathanpallant