Add a feature to stop linking the default panic #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanKadzban
force-pushed
the
no-default-panic
branch
from
e08acd2 to
fae2227
Compare
Urhengulas
approved these changes
Mar 25, 2024
When end-user crates provide a panic handler, this symbol is not needed ... but the linker isn't smart enough to optimize it away, even though the PROVIDE line isn't used (the symbol is provided by the rust function tagged with #[panic_handler]). Those crates can enable this feature to remove the PROVIDE line from the linker script, to stop linking this default panic handler.
Urhengulas
force-pushed
the
no-default-panic
branch
from
2d50420 to
7f34be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When end-user crates provide a panic handler, this symbol is not needed ... but the linker isn't smart enough to optimize it away, even though the PROVIDE line isn't used (the symbol is provided by the rust function tagged with #[panic_handler]). Those crates can enable this feature to remove the PROVIDE line from the linker script, to stop linking this default panic handler.
See #588 for some info.