Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tag in resolved references #109

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

jonjohnsonjr
Copy link
Collaborator

If a single tag is explicitly set (i.e. it's not "latest"), include that
in the reference that gets rendered in the yaml.

This is really useful for tracking releases.

Fixes #108

Also fixes a TODO.

If a single tag is explicitly set (i.e. it's not "latest"), include that
in the reference that gets rendered in the yaml.

This is really useful for tracking releases.
@jonjohnsonjr jonjohnsonjr requested a review from imjasonh November 7, 2019 21:43
@jonjohnsonjr
Copy link
Collaborator Author

One tag:

$ ko publish -B -t hello ./cmd/ko
2019/11/07 13:45:38 Using base gcr.io/distroless/static:latest for github.com/google/ko/cmd/ko
2019/11/07 13:45:38 Building github.com/google/ko/cmd/ko
2019/11/07 13:45:41 Publishing gcr.io/jonjohnson-test/ko/ko:hello
2019/11/07 13:45:42 Published gcr.io/jonjohnson-test/ko/ko:hello@sha256:545110ba5bbd8290575ec034b2caf49de8f665d41368bef6f4a955878780944f
gcr.io/jonjohnson-test/ko/ko:hello@sha256:545110ba5bbd8290575ec034b2caf49de8f665d41368bef6f4a955878780944f

Two tags:

$ ko publish -B -t hello -t world ./cmd/ko
2019/11/07 13:45:56 Using base gcr.io/distroless/static:latest for github.com/google/ko/cmd/ko
2019/11/07 13:45:56 Building github.com/google/ko/cmd/ko
2019/11/07 13:46:00 Publishing gcr.io/jonjohnson-test/ko/ko:hello
2019/11/07 13:46:01 Tagging gcr.io/jonjohnson-test/ko/ko:world
2019/11/07 13:46:02 Published gcr.io/jonjohnson-test/ko/ko@sha256:545110ba5bbd8290575ec034b2caf49de8f665d41368bef6f4a955878780944f
gcr.io/jonjohnson-test/ko/ko@sha256:545110ba5bbd8290575ec034b2caf49de8f665d41368bef6f4a955878780944f

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😻

Copy link

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@imjasonh imjasonh merged commit 7893c74 into ko-build:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve with tag should use the full reference
4 participants