Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS Lambda advanced docs #1281

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix AWS Lambda advanced docs #1281

merged 1 commit into from
Apr 18, 2024

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Apr 18, 2024

No description provided.

@cpanato
Copy link
Member

cpanato commented Apr 18, 2024

please sign the DCO

thanks for the PR!

docs/advanced/lambda.md Outdated Show resolved Hide resolved
Signed-off-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>
imjasonh
imjasonh previously approved these changes Apr 18, 2024
@imjasonh imjasonh enabled auto-merge (rebase) April 18, 2024 12:02
auto-merge was automatically disabled April 18, 2024 12:03

Head branch was pushed to by a user without write access

@cpanato cpanato enabled auto-merge April 18, 2024 12:04
@mattn
Copy link
Contributor Author

mattn commented Apr 18, 2024

Ooops, race condition of commit & you comment. :(
I updated the Go code. (replaced 4 spaces into tabs)

@cpanato cpanato merged commit d988fd3 into ko-build:main Apr 18, 2024
42 checks passed
@mattn
Copy link
Contributor Author

mattn commented Apr 18, 2024

BTW, I'm trying ko with AWS Lambda, but it seems that ko build require --bare for AWS ECR. The docs is correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants