fix(debug): ensure reproducible builds in debug mode #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When use `--debug` build flag, a new dlv executable file is built into the image. However, during the build, some build flags are not specified, resulting in the binary being different each time, which ultimately causes the digest of the image to be inconsistent. This change aims to ensure that, as long as the remote dlv code has not been updated, the digest remains consistent with each build.
l-qing
commented
Nov 24, 2024
| @@ -331,6 +331,8 @@ func getDelve(ctx context.Context, platform v1.Platform) (string, error) { | |||
| // install delve to tmp directory | |||
| args := []string{ | |||
| "build", | |||
| "-trimpath", | |||
There was a problem hiding this comment.
-
trimpath:- Perfectly Reproducible, Verified Go Toolchains
- For Go programs that don’t need cgo, a reproducible build is as simple as compiling with CGO_ENABLED=0 go build -trimpath. Disabling cgo removes the host C toolchain as a relevant input, and
-trimpath removes the current directory.
- For Go programs that don’t need cgo, a reproducible build is as simple as compiling with CGO_ENABLED=0 go build -trimpath. Disabling cgo removes the host C toolchain as a relevant input, and
- Perfectly Reproducible, Verified Go Toolchains
-
"-ldflags=-s -w"- [Go: Reproducible Builds](Go: Reproducible Builds)
-ldflags: reduce binary size by removing debug tables-trimpath: remove paths from stacktraces
- [Go: Reproducible Builds](Go: Reproducible Builds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use
--debugbuild flag, a new dlv executable file is built into the image. However, during the build, some build flags are not specified, resulting in the binary being different each time, which ultimately causes the digest of the image to be inconsistent.This change aims to ensure that, as long as the remote dlv code has not been updated, the digest remains consistent with each build.