Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all varchar db columns used as binary to binary format #94

Closed
4 tasks done
stevewgr opened this issue Aug 10, 2022 · 3 comments
Closed
4 tasks done

Convert all varchar db columns used as binary to binary format #94

stevewgr opened this issue Aug 10, 2022 · 3 comments
Assignees
@srmeier @stevewgr
Labels
enhancement New feature or request

Comments

@stevewgr
Copy link
Member

stevewgr commented Aug 10, 2022 •
edited
Loading

Description

Note that there are some columns in database being read as binary, but specify column data type as varchar.

This causes other issues, as it breaks scripting when special characters are produced from the binary format, varchar is being treated as string.

Tasks

  • Convert USERDATA strSkill and strItem to binary
  • Update all dependents stored procedures to use binary format
  • Verify that server code reads it right
  • Produce a migration script and a PR for ko-db repo
@stevewgr stevewgr added the enhancement New feature or request label Aug 10, 2022
@stevewgr stevewgr self-assigned this Aug 10, 2022
@ko4life-psko ko4life-psko moved this to In Progress in ko-project Aug 11, 2022
@xGuTeK xGuTeK assigned xGuTeK and unassigned stevewgr Oct 18, 2022
@stevewgr
Copy link
Member Author

@xGuTeK, let me know if interesting working on this, otherwise I'll un-assign you so that it's easier to know who is working on what.

@stevewgr stevewgr removed the blocker Use this label to mark a ticket that is currently on hold. label Jun 29, 2023
@stevewgr stevewgr moved this from In Progress to Backlog in ko-project Jun 29, 2023
@stevewgr stevewgr mentioned this issue Jul 1, 2023
Closed
3 tasks
@stevewgr stevewgr mentioned this issue Jul 31, 2023
Merged
srmeier added a commit that referenced this issue Mar 27, 2024
@srmeier
Adjusting DB types for USERDATA table to start addressing issue #94
0440008
@srmeier srmeier mentioned this issue Mar 27, 2024
Merged
4 tasks
@srmeier
Copy link
Contributor

srmeier commented Mar 27, 2024

The [UPDATE_WAREHOUSE] procedure and WAREHOUSE table also need adjusting.

stevewgr pushed a commit that referenced this issue Apr 30, 2024
@srmeier @stevewgr
Adapt database changes for binary columns.
70966f7 
Now character data will be properly saved.

@srmeier:
+ Update variable name to reflect datatype
+ Adjusting DB dtypes for USERDATA table to start addressing issue #94
stevewgr added a commit that referenced this issue Apr 30, 2024
@stevewgr
Merge pull request #214 from ko4life-net/adjust-userdata-db-types
0be3fd0 
Adjusting DB types for USERDATA table to start addressing issue #94
@stevewgr
Copy link
Member Author

Nice work @srmeier! Thanks for the help with that. We can now close this ticket as solved. 🎉

@github-project-automation github-project-automation bot moved this from Backlog to Done in ko-project Apr 30, 2024
@stevewgr stevewgr mentioned this issue Apr 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srmeier srmeier

@stevewgr stevewgr

Labels
enhancement New feature or request
Projects
ko-project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srmeier @xGuTeK @stevewgr