Load & use DB config in recordsets #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 23, 2024 12:44
This behaves similarly to official, with the only difference it uses a shared method in CServerDlg (etc) to construct the connection string from members of CServerDlg, whereas officially it accesses this externally, e.g.: CString strConnect; strConnect.Format(..., m_pMain->m_strGameDSN, ...);
stevewgr
reviewed
May 23, 2024
There was a problem hiding this comment.
Awesome work @twostars 🚀 and also thanks for your efforts in explaining how it was done officialy and wrongly xD I like your approach more with the cerntralized function to get the connection string, as well as the singleton approach. That will be also helpful in the long run as more code is added later.
Just one nit-pick comment, let me know if you have the patience to apply, otherwise I'll just merge it.
stevewgr
added a commit
that referenced
this pull request
Nov 20, 2024
This change updates the LoginServer connection string to be loaded from server.ini instead of Version.ini. This ensures all server files share a unified configuration source, improving maintainability. This adjustment also fixes twostars changes in PR #226. Future improvements to better structure sections across server files will follow in a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This behaves similarly to official, with the only difference it uses a shared method in CServerDlg (etc.) to construct the connection string from members of CServerDlg (etc.), whereas officially it accesses this externally, e.g.:
💔Thank you!