Koa2

[omsmith]

No description provided.

[tj]

woot 👍

I almost wonder if we should wait for async/await to upgrade middleware, since everyone will probably want to convert them to that after anyway and it's a more direct translation

[omsmith]

We could compile ahead of time, but then we're just back to generators (and we may as well just co.wrap all of these.).

Don't think this is too large of an effort.

[tj]

To me 2.0 is useless until async/await is native, transpiling on the server is just weird if you really don't have to, or at least have a compelling reason to

[fengmk2]

It's back to callback style.

Can we make to change to next branch?
If user want to use, publish a new major version like 3.0.0-alpha.1?

I maintaining a lot of koa@1 applications inside and they're hard to upgrade to koa@2.
I don't think this is the time to use koa@2 ready for most people.

[tejasmanohar]

@omsmith -

We could compile ahead of time, but then we're just back to generators (and we may as well just co.wrap all of these.).

I def disagree. Co's built in generator hacky-ness, attempting to fake coroutines with generators (a synchronous feature), and using this for promise-based control flow is meh. Async/await is an actual language feature and is merely a Promise then() handler so there's a huge advantage... it's not at all "back to generators" ;)

[omsmith]

@tejasmanohar I was referring to if we were to use Babel to write these middleware with async/await and publish compiled code, it would be implemented with generators, just as is used today

[omsmith]

s/implemented/polyfilled

[tejasmanohar]

@omsmith Depends on the settings used. IIRC, Babel can transpile async functions into fake coroutines like Co or promise-handling ES5- just depends on the options / presets chosen in v6.

[omsmith]

I added a commit that hoists the functions out, just to play with it

[jonathanong]

@omsmith there's a lot of style changes here that mess everything up. ex. you have mixed spaces and tabs. please try to avoid doing that next time, but i'll fix it myself this time.

[jonathanong]

https://github.com/koajs/etag/compare/v2.x

[omsmith]

Hmm, you're quite right - usually notice that. Thanks ;)

[jonathanong]

oops it's really this branch https://github.com/koajs/etag/tree/v3.x