chore: Use single console.error() statement in error handler (#1471)

koajs · Jun 13, 2020 · 5208c5e · 5208c5e
1 parent 9ee6584
commit 5208c5e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/application.js b/lib/application.js
@@ -201,9 +201,7 @@ module.exports = class Application extends Emitter {
     if (this.silent) return;
 
     const msg = err.stack || err.toString();
-    console.error();
-    console.error(msg.replace(/^/gm, '  '));
-    console.error();
+    console.error(`\n${msg.replace(/^/gm, '  ')}\n`);
   }
 };
 

diff --git a/test/application/onerror.js b/test/application/onerror.js
@@ -51,7 +51,7 @@ describe('app.onerror(err)', () => {
       if (input) msg = input;
     });
     app.onerror(err);
-    assert(msg === '  Foo');
+    assert(msg === '\n  Foo\n');
   });
 
   it('should use err.toString() instad of err.stack', () => {
@@ -68,6 +68,6 @@ describe('app.onerror(err)', () => {
       if (input) msg = input;
     });
     app.onerror(err);
-    assert(msg === '  Error: mock stack null');
+    assert(msg === '\n  Error: mock stack null\n');
   });
 });