Improve checks for Error in onerror handlers #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
commented
Jun 2, 2020
| expose: true | ||
| }); | ||
|
|
||
| assert.doesNotThrow(() => app.onerror(error)); |
There was a problem hiding this comment.
I checked that this is failing in master.
julienw
commented
Jun 2, 2020
| .get('/') | ||
| .expect(418); | ||
|
|
||
| await gotRightErrorPromise; |
There was a problem hiding this comment.
I checked that both assertions are failing in master.
julienw
commented
Jun 2, 2020
| @@ -248,7 +281,7 @@ describe('ctx.onerror(err)', () => { | |||
| }); | |||
|
|
|||
| app.use(async ctx => { | |||
| throw {key: 'value'}; // eslint-disable-line no-throw-literal | |||
| throw { key: 'value' }; // eslint-disable-line no-throw-literal | |||
There was a problem hiding this comment.
Looks like my editor fixed some lint warnings automatically, please tell me if you'd prefer that I revert that.
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 4 4
Lines 485 489 +4
Branches 132 136 +4
=======================================
+ Hits 482 486 +4
Partials 3 3
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466