Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more typings for application's context and request/response #1726

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

mihailik
Copy link
Contributor

@mihailik mihailik commented Dec 7, 2022

Few extra JSDoc decorations that convey types so end-users of the library get better experience:

Screenshot 2022-12-07 at 13 49 03

Similar to #1607 and the suggestion by @jaydenseric except no project changes, just tweaking JSDoc 👍

Copy link
Contributor Author

@mihailik mihailik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed space

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 99.61% // Head: 99.61% // No change to project coverage 👍

Coverage data is based on head (33a4dc9) compared to base (9d2afef).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1726   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files           5        5           
  Lines         521      521           
  Branches      145      145           
=======================================
  Hits          519      519           
  Misses          2        2           
Impacted Files Coverage Δ
lib/application.js 98.43% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit edc35ac into koajs:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants