Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support web WHATWG #1830

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

kravorkid
Copy link
Contributor

Feat to handle WHATWG #1777
I'm open to any suggestions

Checklist

  • [x ] I have ensured my pull request is not behind the main or master branch of the original repository.
  • [x ] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • [x ] I have written a commit message that passes commitlint linting.
  • [x ] I have ensured that my code changes pass linting tests.
  • [x ] I have ensured that my code changes pass unit tests.
  • [x ] I have described my pull request and the reasons for code changes along with context if necessary.

@fengmk2 fengmk2 linked an issue Jun 25, 2024 that may be closed by this pull request
2 tasks
@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2024

Should convert the body data type on respond https://github.com/koajs/koa/blob/master/lib/application.js#L302

A full http request test needs to be added to ensure that the response content is the expected result.
e.g.: https://github.com/koajs/koa/blob/master/__tests__/application/respond.js#L175

@fengmk2 fengmk2 self-requested a review June 25, 2024 23:54
@fengmk2 fengmk2 self-assigned this Jun 25, 2024
@kravorkid
Copy link
Contributor Author

@fengmk2 i've converted body data type and added some tests.
I'm not working on that kind of data on a daily basis so i'm quite unsure if i'm testing the right thing & every corner case
Just tell me if something is missing 🙂

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 changed the title Feat: add support web WHATWG feat: add support web WHATWG Jun 28, 2024
@fengmk2 fengmk2 merged commit 8d5beb3 into koajs:master Jun 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Support Web (WHATWG) stream, Blob and Response
2 participants