make sure all intermediate stream bodies will be destroy #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm +1 to this, but of course this is slightly opinionated as to stream handling. i think TJ wanted to wait to see whether core was adding better error handling, but the last thing i want to do is rely on core to add or fix anything. up to @visionmedia ! |
This was referenced Apr 9, 2014
|
+1, help user to clean up his leave trash. |
|
cool ill review this and the other mods soon |
|
any suggestion for this one? @visionmedia |
| onFinished(this, destroy.bind(null, val)); | ||
|
|
||
| // make sure all intermediate streams has an listenner on error | ||
| inject(val, this.ctx.onerror); |
There was a problem hiding this comment.
probably fine in most cases without this, I don't see people actually registering it themselves they'll just forget or whatever and onerror is semi-private anyway
|
LGTM |
tj
added a commit
that referenced
this pull request
Apr 14, 2014
make sure all intermediate stream bodies will be destroy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure all intermediate stream bodies will be destroy and have error listener(ctx.onerror).