Add option to throw error instead of setting body #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to centralize all application errors in a single error handler, but currently this is not possible because the ratelimit middleware automatically handles it. My suggestion, implemented in this PR, is to pass a new option (
throw: true
) to throw the error instead, allowing a custom error handler to process it.I considered making this the default option, since
this.throw
makes it somewhat compatible with koa's built-in error handler. However, this is not the case because all headers are removed from the response, sox-ratelimit-limit
,x-ratelimit-remaining
andx-ratelimit-reset
would be missing from the response.