feat: add exclusive option
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this is not merged? |
because maintainers weren't notified :) |
etroynov
suggested changes
Jun 30, 2022
| @@ -31,6 +31,7 @@ Create a new router. | |||
| | --- | --- | --- | | |||
| | [opts] | <code>Object</code> | | | |||
| | [opts.prefix] | <code>String</code> | prefix router paths | | |||
| | [opts.exclusive] | <code>Boolean</code> | only run last matched route's controller when there are multiple matches | | |||
There was a problem hiding this comment.
could you add some examples?
There was a problem hiding this comment.
If you want to add examples in another PR that'd be cool! If not no worries.
|
We have just published https://github.com/koajs/router/releases/tag/v11.0.0 This project is maintained by Forward Email and Lad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95
This PR introduces an
exclusiveboolean option, that makes the router only execute the most specific layer (last match if i understand correctly) when there are multiple route matches for a request url.c.f.
router/lib/router.js
Line 356 in 90dd73c
It is
falseby default, so as not introduce a breaking change.