Merge pull request #10 from koalatiapp/fix-empty-changeset

fix: prevent unnecessary api calls for updates with empty changeset
koalatiapp · Mar 4, 2023 · 88d6b54 · 88d6b54
2 parents 7552529 + f9d026b
commit 88d6b54
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Api/Module/CmsEndpoints.php b/src/Api/Module/CmsEndpoints.php
@@ -92,8 +92,14 @@ public function createCollectionItem(string|Collection $collectionId, Collection
 	 */
 	public function updateCollectionItem(string|Collection $collectionId, CollectionItem $item, bool $publishImmediately): CollectionItem
 	{
+		$changeset = $item->getChangeset();
+
+		if (! $changeset) {
+			return $item;
+		}
+
 		$payload = [
-			'fields' => $item->getChangeset(),
+			'fields' => $changeset,
 		];
 		$url = "/collections/{$collectionId}/items/{$item}";
 

diff --git a/src/Api/Module/MembershipEndpoints.php b/src/Api/Module/MembershipEndpoints.php
@@ -56,6 +56,10 @@ public function updateUser(string|Site $siteId, User $user): User
 		$payload = $user->getChangeset();
 		unset($payload['email'], $payload['password']);
 
+		if (! $payload) {
+			return $user;
+		}
+
 		$response = $this->request('PATCH', "/sites/{$siteId}/users/{$user}", $payload);
 
 		if (! $response['valid']) {