Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupedTransformer with transformers that use y #624

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

FBruzzesi
Copy link
Collaborator

Description

Fixes #459 by passing y when fitting the global transformer as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (flake8)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

@FBruzzesi FBruzzesi changed the title Patch/grouped transformer target GroupedTransformer with transformers that use y Mar 6, 2024
Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koaning koaning merged commit a3c8c75 into koaning:main Mar 6, 2024
14 checks passed
@FBruzzesi FBruzzesi deleted the patch/grouped-transformer-target branch April 10, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GroupedTransformer can't deal with transformers that use y
2 participants