Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster-Kfold. Now with correct spelling! #636

Merged
merged 9 commits into from
Mar 24, 2024
Merged

Cluster-Kfold. Now with correct spelling! #636

merged 9 commits into from
Mar 24, 2024

Conversation

koaning
Copy link
Owner

@koaning koaning commented Mar 23, 2024

WIP: fixes #630.

@koaning koaning changed the title WIP: Cluster-Kfold cross validation Cluster-Kfold. Now with correct spelling! Mar 23, 2024
@koaning
Copy link
Owner Author

koaning commented Mar 23, 2024

@FBruzzesi let me know if this feels good.

@koaning koaning requested a review from FBruzzesi March 23, 2024 19:20
Copy link
Collaborator

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only left a comment for the docstring and versioning.
Let me know if that's reasonable, otherwise we merge it as is

sklego/model_selection.py Outdated Show resolved Hide resolved
koaning and others added 3 commits March 24, 2024 14:09
Copy link
Collaborator

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FBruzzesi FBruzzesi merged commit d321198 into main Mar 24, 2024
18 checks passed
@FBruzzesi FBruzzesi deleted the cluster-kfold branch March 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Document KlusterFoldValidation
2 participants