feat: numpy 2.0rc support #651
Conversation
| uv pip install ${{ matrix.pre-release-dependencies }} -e ".[test-all]" --system | ||
| uv pip freeze | ||
| - name: Test with pytest | ||
| run: pytest -n auto --disable-warnings --cov=sklego -m "cvxpy or formulaic or umap" |
There was a problem hiding this comment.
I wonder ... is the -m part needed here? Don't we test for everything by default?
There was a problem hiding this comment.
Oh true, by default everything is tested, with such flag just the extras. I was thinking doing a sort of "delta".
There was a problem hiding this comment.
That can still be a good idea. I guess we could first do a run without those marked tests and then run a step for each of them. Just make sure that you always run each step.
There was a problem hiding this comment.
I split each extra using matrix, it gets a little spammy but very detailed (example)
| uv pip freeze | ||
| - name: Test with pytest | ||
| run: pytest -n auto --disable-warnings --cov=sklego -m "not cvxpy and not formulaic and not umap" |
There was a problem hiding this comment.
As far as I know, there is no easy way to ask only for those tests without a "registered" mark.
I tried to achieve that dynamically via pytest_collection_modifyitems, but it's a bit of a headache as @pytest.mark.parametrize and any other pytest marker count as a mark in the items
Description
There are 3 folds on this PR:
np.lib.padtonp.padnp.NaNtonp.nannumpy<2.0for cvxpy and umap extra dependencies: it is out of our control for them to support latest numpy version.Edit: Manual trigger of cron gha is successful