Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: .drop(columns=...) test hotfix #678

Merged
merged 2 commits into from
Jun 15, 2024
Merged

patch: .drop(columns=...) test hotfix #678

merged 2 commits into from
Jun 15, 2024

Conversation

FBruzzesi
Copy link
Collaborator

Description

Fix a test that is failing in CI (--pre flag) since polars does not support the columns keyword in drop method.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch! Should I make a release for this one?

@koaning koaning merged commit ada798b into main Jun 15, 2024
18 checks passed
@koaning koaning deleted the patch/drop-columns branch June 15, 2024 10:25
@FBruzzesi
Copy link
Collaborator Author

It's just a test, nothing changes in the source code. However we could do 0.9.1 due to #675 and #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants