Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: strict=False in polars constructor #684

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

FBruzzesi
Copy link
Collaborator

Description

I wonder how this was not failing before, anyway, now all polars constructors in test_pandas_utils use the strict=False flag

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

@FBruzzesi FBruzzesi changed the title patch: polars strict=False in constructor patch: strict=False in polars constructor Jul 2, 2024
@koaning koaning merged commit 01cc7e7 into main Jul 2, 2024
18 checks passed
@koaning koaning deleted the patch/ci-cd-hotfix-pl1.0 branch July 2, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants