App automate compatibility to BS Helper with CodeceptJS #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobenguyent
reviewed
Dec 18, 2023
kobenguyent
reviewed
Dec 19, 2023
|
|
||
| async exposeBuildLink (sessionId:string, currentConfig:any, defaultBsAuth:any) { | ||
| const res = await api.makeGetRequest(`${bsEndpoint}/automate/sessions/${sessionId}.json`, { ...defaultBsAuth }); | ||
| async exposeBuildLink(sessionId, currentConfig, defaultBsAuth, helper) { |
Owner
There was a problem hiding this comment.
please add type if possible here
kobenguyent
reviewed
Dec 19, 2023
| const res = await api.makeGetRequest(`${bsEndpoint}/automate/sessions/${sessionId}.json`, { ...defaultBsAuth }); | ||
| async exposeBuildLink(sessionId, currentConfig, defaultBsAuth, helper) { | ||
| let res; | ||
| if (helper.helpers.Appium) { |
Owner
There was a problem hiding this comment.
I'm thinking of a function to return the corresponding BS endpoint instead of we use if else here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kobenguyent could you review it once, if changes needed let me, I have tested it locally