Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow form builder to open forms using deprecated metadata, but then force those metadata to be disabled #3937

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

jnm
Copy link
Member

@jnm jnm commented Jul 14, 2022

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes: Document that simserial and subscriberid are deprecated docs#286

Description

The simserial and subscriberid metadata cannot be read from contemporary devices (#2842) and were removed entirely from the form builder in #3836, but that caused an error when trying to load old forms that had already enabled these metadata. This change allows those forms to be loaded without error, but the obsolete metadata are then disabled as soon as the form is saved.

Related issues

Part of #2842
Related to #3836

metadata (`simserial` and `subscriberid`) without error, but then force
those metadata to be disabled
@jnm jnm merged commit 8760848 into release/2.022.24 Jul 14, 2022
@jnm jnm deleted the formbuilder-handle-deprecated-metadata branch July 14, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority To be done soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants