Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add django-allauth for Azure authentication (SSO) and email verification #4163

Merged
merged 115 commits into from
Jan 9, 2023
Merged

Add django-allauth for Azure authentication (SSO) and email verification #4163

merged 115 commits into from
Jan 9, 2023

Conversation

bufke
Copy link
Contributor

@bufke bufke commented Nov 28, 2022 •
edited
Loading

Description

  • Migrate to django-allauth accounts framework
  • Require email verification when changing an email
  • Require POST for logout.
  • Make email field of Current User ViewSet (/me/) read-only
  • Provide new /me/emails/ ViewSet to add/list/delete unconfirmed emails, in order to change the user's primary email.
  • Add Microsoft Graph (Azure) OAuth provider
  • Change user interface for editing user settings and security settings. Move email and change password to security page.

Implementation Details

django-allauth was deemed the best option for it's support of many oauth clients. Drawbacks include a lack of true multi-tenant configuration and lack of proper OIDC support. We could add both features in theory, ourselves.

  • Port django registration templates/logic to allauth
  • Make logout require a POST (best practice) frontend was modified to support this
  • Add Microsoft Azure Active Directory authentication via django-allauth package but disabled by default

Renamed branch #4034

Docs change

bufke and others added 19 commits October 24, 2022 13:37
@bufke
Add django allauth package
5ea54e4
@bufke
configure allauth
929021d
@bufke
Switching from django registration to allauth accounts
25857e6
@bufke
allauth account templates
7a21e7e
@bufke
Allauth based registration open
f9be119
@bufke
MFA password login now works with new accounts app
17a470e
@bufke
Fix mfa login tests
315e167
@bufke
Fix merge
9f22887
@bufke
Add email verification allauth migration
7d3962b
@bufke
Move mfa to accounts subdirectory
6e9ab8b
@JacquelineMorrissette @bufke
refactor confirmation emails for allauth
607693d
@bufke
isort + black
203e3d0 
Port user signup extra_details to allauth
@bufke
create kobo superuser should automatically verify the email
f1d1444
@JacquelineMorrissette
fix registration unit tests
5a349de
@JacquelineMorrissette
Merge remote-tracking branch 'origin/django-allauth' into django-allauth
597c6f0
@bufke
Merge branch 'accounts-splitup' of github.com:kobotoolbox/kpi into dj…
e34f181 
…ango-allauth
@bufke
Fix allauth username field validation
b848058
@bufke
Start emails endpoint
51d80d3
@bufke
Merge branch 'beta' of github.com:kobotoolbox/kpi into feature/sso
82bedfd
@bufke bufke mentioned this pull request Nov 28, 2022
Closed
bufke and others added 12 commits December 20, 2022 16:09
@bufke
Merge branch 'feature/sso' of github.com:kobotoolbox/kpi into feature…
ef39c1c 
…/sso
@p2edwards
Add a social_app response dict entry for CI tests
ca50cc3
@p2edwards
Add (required) label indicators to user metadata based on constance cfg
62940e8 
This commit doesn't include indicators for required social media, as
those would need some additional styling. The feedback from validation
on save will highlight missing fields in red, including social media.
@p2edwards
Redirect /accounts/register to /accounts/signup
8549f9e
@p2edwards
Fix scrollbar position and fields being obscured in /account/settings
0c146ae
@bufke
Migrate extra user profile data to remove any nested values
bd2f042
@bufke
run black
0405ec6
@bufke
Ignore accounts migration conflicts
fc6028e
@bufke
Save gender/country/sector values only in Django
2df8e8a
@bufke
Remove test of kludges that were removed
0d11e22
@JacquelineMorrissette
change social_apps type to make local tests pass
3624049
@p2edwards
Refine styles on accounts/security
a39eeae
@p2edwards p2edwards self-assigned this Dec 24, 2022
@bufke bufke mentioned this pull request Jan 5, 2023
Merged
@p2edwards
Update $kobo-mid-blue and remove $kobo-light-mid-blue.
ae6f62e 
Slightly lightens $kobo-mid-blue globally (not used very often)
@bufke bufke merged commit 380ce7b into beta Jan 9, 2023
This was referenced Feb 15, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p2edwards p2edwards p2edwards left review comments

@magicznyleszek magicznyleszek magicznyleszek approved these changes

Assignees

@p2edwards p2edwards

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bufke @magicznyleszek @p2edwards @JacquelineMorrissette @duvld