Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): org role logic for usage page plan update button TASK-999 #5296

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Nov 25, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Adds logic to only display "See plans" button for organization owners. Role check is behind a feature flag.

👀 Preview steps

  1. Create an MMO, add an admin.
  2. View usage page with ff_mmosEnabled=true as admin. You should not see the "See plans" button.
  3. View the usage page as organization owner. You should see the "See plans" button".

Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left a non-blocking comment for an implementation idea to see WYT about it!

jsapp/js/account/usage/yourPlan.component.tsx Show resolved Hide resolved
@jamesrkiger jamesrkiger merged commit 522eb19 into main Dec 2, 2024
7 checks passed
@jamesrkiger jamesrkiger deleted the task-999-update-usage-page-for-mmo-roles branch December 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants