Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projectOwnership): set new owner's usage storage correctly #5308

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

noliveleger
Copy link
Contributor

📣 Summary

Fixed an issue where the usage storage for the new owner was not updated correctly during project ownership transfers.

📖 Description

This PR addresses a bug in the project ownership transfer process where the new owner's usage storage was not being updated properly. As a result, storage allocations stayed the same for the previous owner, were not transferred to the new owner, and became inaccurate.

👀 Preview steps

  1. Create a project with attachments
  2. Add data
  3. Transfer the project to another account
  4. With 2.024.33.c previous owner and current owner storage counter are not updated (see UserProfile.attachment_storage_bytes)
  5. With this PR, storage counters are correctly updated

💭 Notes

Previously, when storage counters became out-of-sync, the periodic task sync_storage_counters would eventually catch and correct the discrepancy.

@noliveleger noliveleger self-assigned this Nov 27, 2024
@noliveleger noliveleger changed the base branch from release/2.024.33 to task-1302-sync-counter-lock-users November 27, 2024 17:55
@noliveleger noliveleger requested a review from jnm November 27, 2024 19:03
Base automatically changed from task-1302-sync-counter-lock-users to release/2.024.33 November 27, 2024 19:04
@noliveleger noliveleger changed the base branch from release/2.024.33 to main November 27, 2024 19:05
@noliveleger noliveleger changed the base branch from main to release/2.024.33 November 27, 2024 19:05
@noliveleger noliveleger merged commit 8f19a41 into release/2.024.33 Nov 27, 2024
6 of 7 checks passed
@noliveleger noliveleger deleted the task-1032-fix-transfer-ownership branch November 27, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant