Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): member role selector TASK-986 #5315

Merged
merged 103 commits into from
Dec 11, 2024

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Dec 2, 2024

πŸ“£ Summary

In Members Table (from Account β†’ Team/Organization β†’ Members) add UI for changing member's role.

πŸ“– Description

Only owner and admins can modify the role.

πŸ‘€ Preview steps

  1. ℹ️ have multiple different users
  2. for one of the users (e.g. "joe"), use http://kf.kobo.local/admin/organizations/organization/ to add multiple users into joe's organization
  3. For one of the users (e.g. "sue") set the role to "admin"
  4. enable "Multi-members override" for joe's organization
  5. enable feature flag mmosEnabled
  6. navigate to #/account/organization/members (as "joe")
  7. 🟒 notice that in the table there is no way to change "joe" (owner) role
  8. 🟒 notice that in the table you can change any other user role

As continuation for above steps:

  1. log in as "sue"
  2. navigate to #/account/organization/members
  3. 🟒 notice (again) that in the table there is no way to change "joe" (owner) role (even though you're an "admin")
  4. 🟒 notice that for "sue" you can change the role (to stop being an admin)

πŸ’­ Notes

Build atop #5309

rajpatel24 and others added 30 commits November 7, 2024 01:42
…hook more customizable

and then use it in `MembersRoute`
…hook more customizable

and then use it in `MembersRoute`
@magicznyleszek magicznyleszek marked this pull request as ready for review December 5, 2024 14:42
Copy link
Contributor

@jamesrkiger jamesrkiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment. This is good to merge after reading and/or addressing it.

Copy link
Contributor

@jamesrkiger jamesrkiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

One note: Given the way we are squashing merges now, it would probably be best to merge this into main (after merging the work for task 987) rather than into the 987 branch.

Base automatically changed from task-987-members-table-actions-dropdown to main December 11, 2024 11:53
@magicznyleszek magicznyleszek merged commit 8094a92 into main Dec 11, 2024
7 checks passed
@magicznyleszek magicznyleszek deleted the leszek/task-986-member-role-selector branch December 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants