Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(organizations): add wrapped mantine alert component TASK-1380 #5422

Merged
merged 5 commits into from
Jan 21, 2025
Merged

feat(organizations): add wrapped mantine alert component TASK-1380 #5422

merged 5 commits into from
Jan 21, 2025

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Jan 16, 2025 •
edited
Loading

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Adds a wrapped mantine Alert component together with theming and storybook entry.

👀 Preview steps

Compare the "demo" stories for common/Alert and commonDeprecated/InlineMessage in storybook.

@jamesrkiger jamesrkiger self-assigned this Jan 16, 2025
pauloamorimbr
pauloamorimbr approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌🏻

@jamesrkiger jamesrkiger merged commit e1a2910 into main Jan 21, 2025
7 checks passed
@jamesrkiger jamesrkiger deleted the task-1380-create-mantine-alert-component branch January 21, 2025 19:32
rajpatel24 pushed a commit that referenced this pull request Jan 28, 2025
@jamesrkiger @rajpatel24
feat(organizations): add wrapped mantine alert component TASK-1380 (#…
72d67a6 
…5422)

### 📣 Summary
Adds a wrapped mantine Alert component together with theming and
storybook entry.

### 👀 Preview steps
Compare the "demo" stories for `common/Alert` and
`commonDeprecated/InlineMessage` in storybook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloamorimbr pauloamorimbr pauloamorimbr approved these changes

@magicznyleszek magicznyleszek Awaiting requested review from magicznyleszek magicznyleszek is a code owner

Assignees

@jamesrkiger jamesrkiger

Labels
Front end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesrkiger @pauloamorimbr