Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] Improve cost management integration #275

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

ricoberger
Copy link
Member

Improve the cost management integration in the Azure plugin. The pie
chart for the actual costs uses the same style as the other charts in
kobs. We are now using the chart theme, color scheme and tooltip from
the core package, so that the chart fits the style of the other charts
in kobs and the Azure plugin.

Instead of selecting the time from a dropdown in the cost management
page, it is now possible to select a time range via the Toolbar
component from the core package, like it is done in other plugins.

It is now possible to show the actual costs in a panel on a dashboard.
For this the type "costmanagement" with the sub type "actualcosts" can
be selected in the Azure plugin options. The user can also set a scope
(name of a resource group). If the user doesn't set this value it will
default to "All".

Improve the cost management integration in the Azure plugin. The pie
chart for the actual costs uses the same style as the other charts in
kobs. We are now using the chart theme, color scheme and tooltip from
the core package, so that the chart fits the style of the other charts
in kobs and the Azure plugin.

Instead of selecting the time from a dropdown in the cost management
page, it is now possible to select a time range via the Toolbar
component from the core package, like it is done in other plugins.

It is now possible to show the actual costs in a panel on a dashboard.
For this the type "costmanagement" with the sub type "actualcosts" can
be selected in the Azure plugin options. The user can also set a scope
(name of a resource group). If the user doesn't set this value it will
default to "All".
@codecov-commenter
Copy link

Codecov Report

Merging #275 (e8d5bfe) into main (59c20bf) will increase coverage by 0.62%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   42.16%   42.78%   +0.62%     
==========================================
  Files          92       93       +1     
  Lines        7895     7902       +7     
==========================================
+ Hits         3329     3381      +52     
+ Misses       4529     4484      -45     
  Partials       37       37              
Impacted Files Coverage Δ
...zure/pkg/instance/costmanagement/costmanagement.go 42.10% <0.00%> (+29.60%) ⬆️
plugins/azure/costmanagement.go 78.78% <93.75%> (+5.71%) ⬆️
...ugins/azure/pkg/instance/costmanagement/helpers.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c20bf...e8d5bfe. Read the comment docs.

@ricoberger
Copy link
Member Author

fyi @axdotl

@ricoberger ricoberger merged commit 2e71bc4 into main Jan 1, 2022
@ricoberger ricoberger deleted the azure-improve-cost-management-integration branch January 1, 2022 15:06
@ricoberger ricoberger linked an issue Jan 1, 2022 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azure] Extend plugin functionality
2 participants