Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Extend Placeholders for Dashboards #441

Conversation

ricoberger
Copy link
Member

It is now possible to set a default value for a placeholder in a dashboard and it is possible to set a type for the placeholder.

Until now, it was only possible to use string values for placeholders. This is now changed so that also "numbers" and "objects" can be used.

It is now possible to set a default value for a placeholder in a
dashboard and it is possible to set a type for the placeholder.

Until now, it was only possible to use string values for placeholders.
This is now changed so that also "numbers" and "objects" can be used.
@ricoberger ricoberger force-pushed the app-support-default-values-and-multiple-types-for-placeholders branch from 761b69a to c1902a0 Compare October 13, 2022 12:39
@codecov-commenter
Copy link

Codecov Report

Merging #441 (c1902a0) into main (2a3db93) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   43.90%   43.98%   +0.08%     
==========================================
  Files         143      143              
  Lines       12359    12378      +19     
==========================================
+ Hits         5426     5445      +19     
  Misses       6794     6794              
  Partials      139      139              
Impacted Files Coverage Δ
pkg/hub/api/dashboards/dashboards.go 100.00% <100.00%> (ø)
pkg/hub/api/dashboards/variables.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricoberger ricoberger added the changelog: added A new feature was added label Oct 13, 2022
@ricoberger ricoberger merged commit cdfaeb8 into main Oct 13, 2022
@ricoberger ricoberger deleted the app-support-default-values-and-multiple-types-for-placeholders branch October 13, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: added A new feature was added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants