[db] Use UnixMilli() instead of Unix() for createdAt / updatedAt #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scthi
force-pushed
the
improve-db-test-performance-2
branch
2 times, most recently
from
8691e36 to
d00771c
Compare
scthi
force-pushed
the
improve-db-test-performance
branch
from
9f35d11 to
57fd1d2
Compare
scthi
force-pushed
the
improve-db-test-performance-2
branch
3 times, most recently
from
4432a6b to
2832e75
Compare
The increased precision avoids the need of time.Sleep() in tests
scthi
force-pushed
the
improve-db-test-performance-2
branch
from
2832e75 to
3a9038d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 72.23% 72.22% -0.01%
==========================================
Files 430 430
Lines 66635 66635
Branches 2879 2877 -2
==========================================
- Hits 48132 48127 -5
- Misses 18199 18205 +6
+ Partials 304 303 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ricoberger
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UnixMilli() instead of Unix() for createdAt / updatedAt
The increased precision avoids the need of time.Sleep() in tests
This further reduces the test execution time. For db_test.go down to ~4.5s on my machine.