[mongodb] Fix Collection Filter and Pagination #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pagination and filter on the collections page was not working, because we forgot to add the `filter` and `slice` (for pagination) to the array of collections. This should now be fixed, so that a user can view all collections and filter them.
ricoberger
force-pushed
the
mongodb-fix-collection-pagination-and-filter
branch
from
06a469b to
2d271de
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
===========================================
+ Coverage 72.17% 95.89% +23.71%
===========================================
Files 430 16 -414
Lines 66710 2315 -64395
Branches 2883 196 -2687
===========================================
- Hits 48150 2220 -45930
+ Misses 18256 95 -18161
+ Partials 304 0 -304
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pagination and filter on the collections page was not working, because we forgot to add the
filterandslice(for pagination) to the array of collections. This should now be fixed, so that a user can view all collections and filter them.